linux-kernel - Re: [PATCH] mfd: rtsx: Modify rts5249_optimize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130905104820.GL6329@mwanda>
Date:	Thu, 5 Sep 2013 13:48:20 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	wei_wang@...lsil.com.cn
Cc:	sameo@...ux.intel.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, rogerable@...ltek.com,
	devel@...uxdriverproject.org
Subject: Re: [PATCH] mfd: rtsx: Modify rts5249_optimize_phy

On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_wang@...lsil.com.cn wrote:
> From: Wei WANG <wei_wang@...lsil.com.cn>
> 
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
> 
> Signed-off-by: Wei WANG <wei_wang@...lsil.com.cn>
> ---
>  drivers/mfd/rts5249.c |   25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> index 3b835f5..e3c6dc1 100644
> --- a/drivers/mfd/rts5249.c
> +++ b/drivers/mfd/rts5249.c
> @@ -130,13 +130,34 @@ static int rts5249_optimize_phy(struct rtsx_pcr *pcr)
>  {
>  	int err;
>  
> -	err = rtsx_pci_write_phy_register(pcr, PHY_REG_REV, 0xFE46);
> +	err = rtsx_pci_write_phy_register(pcr, PHY_REG_REV, 0xFC6C);


How are we supposed to review this change?  What happened to 0xFE46?
What are all these magic numbers?  I understand that this fixes an issue
for think pads but does it break something else?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/