[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.02.1309051752500.6397@kaball.uk.xensource.com>
Date: Thu, 5 Sep 2013 17:54:15 +0100
From: Stefano Stabellini <stefano.stabellini@...citrix.com>
To: Catalin Marinas <catalin.marinas@....com>
CC: Stefano Stabellini <stefano.stabellini@...citrix.com>,
"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
"Ian.Campbell@...rix.com" <Ian.Campbell@...rix.com>,
Will Deacon <Will.Deacon@....com>
Subject: Re: [PATCH v5 03/13] arm64: define DMA_ERROR_CODE
On Thu, 5 Sep 2013, Catalin Marinas wrote:
> On Thu, Aug 29, 2013 at 07:32:24PM +0100, Stefano Stabellini wrote:
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > CC: catalin.marinas@....com
> > CC: will.deacon@....com
> > ---
> > arch/arm64/include/asm/dma-mapping.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h
> > index 8d18100..c2cb8a0 100644
> > --- a/arch/arm64/include/asm/dma-mapping.h
> > +++ b/arch/arm64/include/asm/dma-mapping.h
> > @@ -25,6 +25,7 @@
> >
> > #define ARCH_HAS_DMA_GET_REQUIRED_MASK
> >
> > +#define DMA_ERROR_CODE (~0)
>
> I wonder why this isn't more generic. It looks like most (all?)
> architectures define it in the same way.
Actually it's defined as 0 on x86 and ia64.
All the others define it as ~0.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists