linux-kernel - Re: [RFC PATCH 0/3] irq: Fix stack overflow due to softirq called on current stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1378419504.4321.194.camel@pasglop>
Date:	Fri, 06 Sep 2013 08:18:24 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Paul Mackerras <paulus@....ibm.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	James Hogan <james.hogan@...tec.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC PATCH 0/3] irq: Fix stack overflow due to softirq called
 on current stack

On Thu, 2013-09-05 at 17:33 +0200, Frederic Weisbecker wrote:
> Hi,
> 
> This series is a proposition to fix the crash reported here: http://lkml.kernel.org/r/1378330796.4321.50.camel%40pasglop
> And it has the upside to also consolidate a bit the arch do_softirq overriden implementation.
> 
> Only tested in x86-64 for now.

Thanks. I'm off for a few days, Paul can you give that a spin ? My
understanding is that the crash was fairly reproduceable... which makes
me wonder what are the chances to get RH to pick that series up for
RHEL7...

Cheers,
Ben.

> Thanks.
> 
> Frederic Weisbecker (3):
>   irq: Consolidate do_softirq() arch overriden implementations
>   irq: Execute softirq on its own stack on irq exit
>   irq: Comment on the use of inline stack for ksoftirq
> 
>  arch/metag/kernel/irq.c    |   56 +++++++++++++++++------------------------
>  arch/parisc/kernel/irq.c   |   17 +-----------
>  arch/powerpc/kernel/irq.c  |   17 +-----------
>  arch/s390/kernel/irq.c     |   52 +++++++++++++++----------------------
>  arch/sh/kernel/irq.c       |   60 ++++++++++++++++++-------------------------
>  arch/sparc/kernel/irq_64.c |   31 +++++++---------------
>  arch/x86/kernel/irq_32.c   |   34 +++++++++----------------
>  arch/x86/kernel/irq_64.c   |   18 ++-----------
>  include/linux/interrupt.h  |   11 ++++++++
>  kernel/softirq.c           |   10 +++----
>  10 files changed, 112 insertions(+), 194 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/