linux-kernel - Re: [PATCH] VMCI: fix to pass correct device identity to free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130906065556.GA21772@dtor-ws.eng.vmware.com>
Date:	Thu, 5 Sep 2013 23:55:56 -0700
From:	Dmitry Torokhov <dtor@...are.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	acking@...are.com, gregkh@...uxfoundation.org,
	georgezhang@...are.com, asarwade@...are.com,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] VMCI: fix to pass correct device identity to free_irq()

On Fri, Sep 06, 2013 at 02:39:28PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Acked-by: Dmitry Torokhov <dtor@...are.com>

> ---
>  drivers/misc/vmw_vmci/vmci_guest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index b3a2b76..c98b03b 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -649,7 +649,7 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
>  	return 0;
>  
>  err_free_irq:
> -	free_irq(vmci_dev->irq, &vmci_dev);
> +	free_irq(vmci_dev->irq, vmci_dev);
>  	tasklet_kill(&vmci_dev->datagram_tasklet);
>  	tasklet_kill(&vmci_dev->bm_tasklet);
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/