lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Sep 2013 08:03:40 +0100 From: Lee Jones <lee.jones@...aro.org> To: Sachin Kamat <sachin.kamat@...aro.org> Cc: linux-kernel@...r.kernel.org, anton@...msg.org, dwmw2@...radead.org Subject: Re: [PATCH v2 3/4] pm2301-charger: Check return value of regulator_enable On Fri, 06 Sep 2013, Sachin Kamat wrote: > Check the return value of regulator_enable to silence the following > warning: > drivers/power/pm2301_charger.c:725:20: warning: > ignoring return value of ‘regulator_enable’, declared with > attribute warn_unused_result [-Wunused-result] > > Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org> > Cc: Lee Jones <lee.jones@...aro.org> > --- > Compile tested. > Changes since v1: > * converted dev_err and return to dev_warn as suggested by Lee Jones. > --- > drivers/power/pm2301_charger.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c > index ffa10ed..e55d809 100644 > --- a/drivers/power/pm2301_charger.c > +++ b/drivers/power/pm2301_charger.c > @@ -722,8 +722,14 @@ static int pm2xxx_charger_ac_en(struct ux500_charger *charger, > > dev_dbg(pm2->dev, "Enable AC: %dmV %dmA\n", vset, iset); > if (!pm2->vddadc_en_ac) { > - regulator_enable(pm2->regu); > - pm2->vddadc_en_ac = true; > + ret = regulator_enable(pm2->regu); > + if (ret) { > + dev_warn(pm2->dev, > + "Failed to enable vddadc regulator\n"); > + pm2->vddadc_en_ac = false; pm2->vddadc_en_ac is already false. > + } else { > + pm2->vddadc_en_ac = true; > + } > } > > ret = pm2xxx_charging_init(pm2); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists