linux-kernel - Re: [PATCH 1/2] gpio: Fix crash in gpiod_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY4+PxBp_88QB7OrfowQ+6axvaqCj=kviwXmo-aHGwHVg@mail.gmail.com>
Date:	Fri, 6 Sep 2013 10:55:41 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: Fix crash in gpiod_set_debounce()

On Tue, Sep 3, 2013 at 10:25 PM, Stephen Warren <swarren@...dotorg.org> wrote:

>>       chip = desc->chip;
>>       if (!chip->set || !chip->set_debounce) {
>>         pr_warn("%s: missing set() or set_debounce() operations\n",
>>                 __func__);
>> +             return -EIO;
>>       }
>
> BTW, I'm not sure that error-path should pr_warn(). For example, if this
> error-patch is taken due to a call from
> gpio_keys.c:gpio_keys_setup_key(), then a timer will be used for
> debounce instead, which is all perfectly valid, and probably not
> something that should be spewed to the kernel log.

You're right, I wasn't aware of the fallback use-case,
so I've proposed a separate patch fixing this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/