[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130906093800.GF32654@lee--X1>
Date: Fri, 6 Sep 2013 10:38:00 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Sachin Kamat <sachin.kamat@...aro.org>
Cc: linux-kernel@...r.kernel.org, anton@...msg.org, dwmw2@...radead.org
Subject: Re: [PATCH v3 1/4] ab8500-charger: Check return value of
regulator_enable
On Fri, 06 Sep 2013, Sachin Kamat wrote:
> Check the return value of regulator_enable to silence the following
> type of warnings:
> drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value
> of ‘regulator_enable’, declared with attribute warn_unused_result
> [-Wunused-result]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> ---
> Compile tested.
>
> Changes since v2:
> * removed redundant assignment to false.
> Changes since v1:
> * converted dev_err and return to dev_warn as suggested by Lee Jones.
> ---
>
> drivers/power/ab8500_charger.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
Looks good now.
Acked-by: Lee Jones <lee.jones@...aro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists