linux-kernel - Re: [PATCH] staging: r8188eu: Fix uninitialized variable change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXdXRtpYoZBG3poJAvMO+tWVg3J0Z6v2MEv0DgPw==RiA@mail.gmail.com>
Date:	Fri, 6 Sep 2013 16:52:34 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	driverdevel <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: Fix uninitialized variable change_inx

On Fri, Sep 6, 2013 at 4:42 PM, Larry Finger <Larry.Finger@...inger.net> wrote:
> On 09/06/2013 07:45 AM, Geert Uytterhoeven wrote:
>> drivers/staging/rtl8188eu/core/rtw_wlan_util.c: In function
>> ‘WMMOnAssocRsp’:
>> drivers/staging/rtl8188eu/core/rtw_wlan_util.c:634: warning: ‘change_inx’
>> may be used uninitialized in this function
>>
>> And the compiler is right: change_inx should be initialized to false.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> ---
>>   drivers/staging/rtl8188eu/core/rtw_wlan_util.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
>> b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
>> index 013ea48..8018edd 100644
>> --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
>> +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
>> @@ -631,7 +631,7 @@ void WMMOnAssocRsp(struct adapter *padapter)
>>         inx[0] = 0; inx[1] = 1; inx[2] = 2; inx[3] = 3;
>>
>>         if (pregpriv->wifi_spec == 1) {
>> -               u32     j, tmp, change_inx;
>> +               u32     j, tmp, change_inx = false;
>>
>>                 /* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
>>                 for (i = 0; i < 4; i++) {
>>
>
> Acked-by: Larry Finger <Larry.Finger@...inger.net>
>
> This warning has not shown up on my x86_64 system with gcc 4.7.2. What
> architecture and gcc version were you using?

Good old gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21) for m68k.

Recent versions of gcc no longer give warnings for uninitialized variables,
probably because it used to flood you with too many false positives.
This may please the -Werror camp, but once in a while the warnings do disclose
real bugs, so I tend to look at all regressions I encounter there.

I've just checked with m68k-linux-gcc 4.6.3 from crosstool on kernel.org, and
it doesn't give this warning (hmm, it does give other warnings, so I should have
a closer look...).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/