linux-kernel - Re: [PATCH 1/5] iio: adc: remove unnecessary work pending test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130906152028.GA22763@mtj.dyndns.org>
Date:	Fri, 6 Sep 2013 11:20:28 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Xie XiuQi <xiexiuqi@...wei.com>
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Dmitry Torokhov <dtor@...l.ru>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andres Salomon <dilinger@...ued.net>,
	Chris Ball <cjb@...top.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nadia Derbey <Nadia.Derbey@...l.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Li Bin <huawei.libin@...wei.com>
Subject: Re: [PATCH 1/5] iio: adc: remove unnecessary work pending test

On Fri, Sep 06, 2013 at 07:02:34PM +0800, Xie XiuQi wrote:
> Remove unnecessary work pending test before calling schedule_work().
> It has been tested in queue_work_on() already. No functional changed.
> 
> Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>
> Cc: Tejun Heo <tj@...nel.org>

Reviewed-by: Tejun Heo <tj@...nel.org>

One nit below tho.

> -	if (iio_buffer_enabled(indio_dev)) {
> -		if (!work_pending(&st->poll_work))
> -			schedule_work(&st->poll_work);
> -	} else {
> +	if (iio_buffer_enabled(indio_dev))
> +		schedule_work(&st->poll_work);
> +	else {
>  		st->done = true;
>  		wake_up_interruptible(&st->wq_data_avail);
>  	}

Please don't drop the parentheses.  The convention is to have either
both or none on if/else.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/