lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 06 Sep 2013 11:29:17 -0700 From: Sudeep Dutt <sudeep.dutt@...el.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Arnd Bergmann <arnd@...db.de>, Rusty Russell <rusty@...tcorp.com.au>, "Michael S. Tsirkin" <mst@...hat.com>, Rob Landley <rob@...dley.net>, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, linux-doc@...r.kernel.org, Asias He <asias@...hat.com>, Nikhil Rao <nikhil.rao@...el.com>, Ashutosh Dixit <ashutosh.dixit@...el.com>, Caz Yokoyama <Caz.Yokoyama@...el.com>, Dasaratharaman Chandramouli <dasaratharaman.chandramouli@...el.com>, Harshavardhan R Kharche <harshavardhan.r.kharche@...el.com>, "Yaozu (Eddie) Dong" <eddie.dong@...el.com>, Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>, Sudeep Dutt <sudeep.dutt@...el.com> Subject: Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management. On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > Again, very minor fixups for later (I can even do them...) > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); > > DEVICE_ATTR_RW() please. > > Same for the other attributes you create in this patch. > Sure, we will incorporate these changes along with your other feedback in patch 1 and post the next revision of this patch series. Thanks for the review! Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists