linux-kernel - Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522976DC.8080301@oracle.com>
Date:	Fri, 06 Sep 2013 14:31:56 +0800
From:	Bob Liu <bob.liu@...cle.com>
To:	Weijie Yang <weijie.yang@...sung.com>
CC:	sjenning@...ux.vnet.ibm.com, minchan@...nel.org,
	weijie.yang.kh@...il.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning


On 09/06/2013 01:16 PM, Weijie Yang wrote:
> add SetPageReclaim before __swap_writepage so that page can be moved to the
> tail of the inactive list, which can avoid unnecessary page scanning as this
> page was reclaimed by swap subsystem before.
> 
> Signed-off-by: Weijie Yang <weijie.yang@...sung.com>

Reviewed-by: Bob Liu <bob.liu@...cle.com>

> ---
>  mm/zswap.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 1be7b90..cc40e6a 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -556,6 +556,9 @@ static int zswap_writeback_entry(struct zbud_pool *pool, unsigned long handle)
>  		SetPageUptodate(page);
>  	}
>  
> +	/* move it to the tail of the inactive list after end_writeback */
> +	SetPageReclaim(page);
> +
>  	/* start writeback */
>  	__swap_writepage(page, &wbc, end_swap_bio_write);
>  	page_cache_release(page);
> 

-- 
Regards,
-Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/