linux-kernel - Re: crypto/xor.ko fails to build with CONFIG_KERNEL_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <645D2350-5007-4EFF-AFFD-8D51BA006292@linaro.org>
Date:	Sat, 7 Sep 2013 07:56:26 +0200
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Russell King <linux@....linux.org.uk>,
	Nicolas Pitre <nico@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: crypto/xor.ko fails to build with CONFIG_KERNEL_MODE_NEON=y



On 7 sep. 2013, at 04:44, Josh Boyer <jwboyer@...oraproject.org> wrote:

> We enabled CONFIG_KERNEL_MODE_NEON on the armv7hl builds we're doing.
> It builds for a while, but eventually fails when running modpost on
> the xor.ko module:
> 
> ERROR: "xor_block_neon_inner" [crypto/xor.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 

Clearly a bug, thanks for spotting this. I will submit a fix asap. In the mean time, building the xor code into the zImage will help you complete the build.

> I tried adding an EXPORT_SYMBOL_GPL(xor_block_neon_inner); after the
> structure definition in arch/arm/lib/xor-neon.c but that doesn't seem
> to have done anything.
> 

I would expected that to have done the trick, but perhaps it is better to merge the neon code into the main arm/xor source file.

> Before I go chasing this further, I'm curious if anyone else has run into this.
> 

Cheers,
Ard.



> josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/