linux-kernel - Re: [PATCH] simplefb: print some info about the registered fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Sep 2013 13:16:23 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Tom Gundersen <teg@...m.no>
Cc:	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Stephen Warren <swarren@...dotorg.org>
Subject: Re: [PATCH] simplefb: print some info about the registered fb

Hi Tom

On Fri, Sep 6, 2013 at 1:49 PM, Tom Gundersen <teg@...m.no> wrote:
> This is similar to the output printed by efifb.
>
> Signed-off-by: Tom Gundersen <teg@...m.no>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: David Herrmann <dh.herrmann@...il.com>
> ---
>
> Hi,
>
> Sorry for the resend, got the ml address wrong.
>
> -t
>
>  drivers/video/simplefb.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
> index 8d78106..4196686 100644
> --- a/drivers/video/simplefb.c
> +++ b/drivers/video/simplefb.c
> @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
>         }
>         info->pseudo_palette = (void *)(info + 1);
>
> +       dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n",
> +                            info->fix.smem_start, info->screen_base);

Could we get smem_len, too? Something like:
      dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped
to 0x%p\n",
                           info->fix.smem_start, (unsigned
long)info->fix.smem_len, info->screen_base);

(smem_len is __u32, so cast it to avoid truncation if it's defined as
long somewhere. Not sure whether we actually have 16bit int somewhere,
though)

Cheers
David

> +       dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
> +                            params.format->name,
> +                            info->var.xres, info->var.yres,
> +                            info->var.bits_per_pixel,
> +                            info->fix.line_length);
> +
>         ret = register_framebuffer(info);
>         if (ret < 0) {
>                 dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
> --
> 1.8.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/