linux-kernel - Re: [PATCH V2 1/2] perf tools: fix id pos in perf_evlist_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Sep 2013 15:54:10 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	David Ahern <dsahern@...il.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH V2 1/2] perf tools: fix id pos in perf_evlist__open()

Em Sat, Sep 07, 2013 at 08:20:10AM -0600, David Ahern escreveu:
> On 9/6/13 1:40 PM, Adrian Hunter wrote:
> >Ensure the id_pos is correct when perf_evlist__open()
> >is used.
> 
> The commit log should reference 7556257 and breakage of 'kvm stat
> live'; helps identify patches when backporting.
> 
> Other than that this patch fixes the problem.

Thanks, I'm ammending the commit message log.
 
> Tested-by and Acked-by David Ahern <dsahern@...il.com>
> 
> >
> >Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> >---
> >  tools/perf/util/evlist.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> >diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> >index b8727ae..005c0eb 100644
> >--- a/tools/perf/util/evlist.c
> >+++ b/tools/perf/util/evlist.c
> >@@ -64,6 +64,16 @@ void perf_evlist__set_id_pos(struct perf_evlist *evlist)
> >  	evlist->is_pos = first->is_pos;
> >  }
> >
> >+static void perf_evlist__update_id_pos(struct perf_evlist *evlist)
> >+{
> >+	struct perf_evsel *evsel;
> >+
> >+	list_for_each_entry(evsel, &evlist->entries, node)
> >+		perf_evsel__calc_id_pos(evsel);
> >+
> >+	perf_evlist__set_id_pos(evlist);
> >+}
> >+
> >  static void perf_evlist__purge(struct perf_evlist *evlist)
> >  {
> >  	struct perf_evsel *pos, *n;
> >@@ -915,6 +925,8 @@ int perf_evlist__open(struct perf_evlist *evlist)
> >  	struct perf_evsel *evsel;
> >  	int err;
> >
> >+	perf_evlist__update_id_pos(evlist);
> >+
> >  	list_for_each_entry(evsel, &evlist->entries, node) {
> >  		err = perf_evsel__open(evsel, evlist->cpus, evlist->threads);
> >  		if (err < 0)
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/