Message-ID: <3D397F11-B184-4DC0-BEE2-90C91DBABB0B@ti.com>
Date:	Tue, 10 Sep 2013 05:53:16 +0000
From:	"Fernandes, Joel" <joelf@...com>
To:	Koen Kooi <koen@...inion.thruhere.net>
CC:	Kevin Hilman <khilman@...aro.org>,
	"bcousson@...libre.com" <bcousson@...libre.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"tony@...mide.com" <tony@...mide.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"olof@...om.net" <olof@...om.net>
Subject: Re: [PATCH] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black



On Sep 10, 2013, at 12:45 AM, "Koen Kooi" <koen@...inion.thruhere.net> wrote:

> 
> Op 10 sep. 2013, om 01:42 heeft Joel Fernandes <joelf@...com> het volgende geschreven:
> 
>> On 09/09/2013 03:12 PM, Joel Fernandes wrote:
>>> On 09/09/2013 03:00 PM, Koen Kooi wrote:
>>>> 
>>>> Op 9 sep. 2013, om 21:50 heeft Joel Fernandes <joelf@...com> het volgende geschreven:
>>>> 
>>>>> On 09/09/2013 01:51 PM, Joel Fernandes wrote:
>>>>>> On 09/09/2013 01:43 PM, Koen Kooi wrote:
>>>>>>> 
>>>>>>> Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <joelf@...com> het volgende geschreven:
>>>>>>> 
>>>>>>>> On 09/09/2013 10:51 AM, Koen Kooi wrote:
>>>>>>>>> 
>>>>>>>>> Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <khilman@...aro.org> het volgende geschreven:
>>>>>>>>> 
>>>>>>>>>> Koen Kooi <koen@...inion.thruhere.net> writes:
>>>>>>>>>> 
>>>>>>>>>>> The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added,
>>>>>>>>>>> so create a common dtsi both can use.
>>>>>>>>>>> 
>>>>>>>>>>> IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver
>>>>>>>>>>> after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead
>>>>>>>>>>> of 1.8.
>>>>>>>>>>> 
>>>>>>>>>>> MMC support for AM335x still isn't in, so only the LDO change has been added.
>>>>>>>>>>> 
>>>>>>>>>>> Cc: stable@...r.kernel.org
>>>>>>>>>>> 
>>>>>>>>>>> Signed-off-by: Koen Kooi <koen@...inion.thruhere.net>
>>>>>>>>>>> Tested-by: Tom Rini <trini@...com>
>>>>>>>>>>> Tested-by: Matt Porter <matt.porter@...aro.org>
>>>>>>>>>> 
>>>>>>>>>> I guess the subject should've included v5?
>>>>>>>>> 
>>>>>>>>> Yes, I blame it on being monday :)
>>>>>>>> 
>>>>>>>> The series you're posting will require rebasing on the current MMC DT series
>>>>>>>> that is being discussed last couple of weeks on the mailing list which were
>>>>>>>> waiting until now as DMA support was missing. Now that DMA support is pulled in,
>>>>>>>> it is safe to apply those patches so I will be reposting them shortly.
>>>>>>>> 
>>>>>>>> Please hold off any changes until those patches are posted. This will avoid
>>>>>>>> unnecessary conflicts.
>>>>>>> 
>>>>>>> Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.
>>>>>> 
>>>>>> That's fair enough, since  Kevin Acked and Benoit is pulling it, I'm fine with
>>>>>> rebasing on top of it and we avoid any merge conflicts.
>>>>> 
>>>>> I noticed - there were still some comments from Felipe on the v4 series of this
>>>>> patch regarding RF cape and HDMI may be breaking it. How are you addressing that?
>>>> 
>>>> Capes will never go into the .dts and HDMI support needs some serious patching before it can get enabled in the DT. And the RF cape isn't being sold since it has no sw support. No need to worry about things in the 3.15/3.16 timeframe. Unless you want this LDO3 fix not to go in ASAP.
>>>> 
>>>> Joel, is there anything relevant *right now* blocking this patch going in? If not, please test it and add your Tested-by: line.
>>> 
>>> We don't merge things in hurry and focus is to do things the right way.. I just
>>> want to make sure that all possible comments have been addressed.
>>> 
>>> Otherwise patch looks OK and hope everyone else thinks so too. I am dealing with
>>> some merge conflicts right now with my series on top of this though, but they
>>> should be easy enough to fix up. That's delaying my testing, but otherwise as
>>> such I don't have any objection to this patch (provided the conclusion is that
>>> all comments have been addressed..). Thanks!
>> 
>> Koen,
>> 
>> One note though, since I don't use HDMI (or BBB much for that matter), I was ok
>> with taking a risk of upping the ldo3 regulator voltage to 3.3v on my board
>> which I needed to do to get to the boot prompt.
>> I applied my AM335x DMA and MMC patches and tried to boot with rootfs as MMC1.
>> 
>> With 1.8v, I get the following during boot:
>> [    2.236043] mmc0: host doesn't support card's voltages
>> [    2.241659] mmc0: error -22 whilst initialising SD card
>> 
>> That's strange because I do have an SDHC card. With 3.3v it works fine.
>> 
>> I will add a note about this to my series. Since this more of an MMC issue than
>> anything, and your patch series doesn't enable MMC, you can add my tested-by:
>> 
>> Tested-by: Joel Fernandes <joelf@...com>
>> 
>> Later on, the regulator voltage may need to be tweaked for MMC support.
> 
> See https://lkml.org/lkml/2013/9/6/95 and https://lkml.org/lkml/2013/9/6/183

Ok since you said in above thread you'll rebase the card detect and the regulator fixes , I'll let you do that and drop my drop my hacked mmc1 patch for BBB from my series.

Regards,

-Joel--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists