linux-kernel - RE: [PATCHv3 2/4] ARM: dts: Add Freescale FTM PWM node for VF610.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1DD289F6464F0949A2FCA5AA6DC23F828136F5@039-SN2MPN1-013.039d.mgd.msft.net>
Date:	Tue, 10 Sep 2013 08:10:09 +0000
From:	Xiubo Li-B47053 <B47053@...escale.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
CC:	Guo Shawn-R65073 <r65073@...escale.com>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"rob@...dley.net" <rob@...dley.net>,
	"ian.campbell@...rix.com" <ian.campbell@...rix.com>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: RE: [PATCHv3 2/4] ARM: dts: Add Freescale FTM PWM node for VF610.

> > diff --git a/arch/arm/boot/dts/vf610.dtsi
> > b/arch/arm/boot/dts/vf610.dtsi index 67d929c..44787b5 100644
> > --- a/arch/arm/boot/dts/vf610.dtsi
> > +++ b/arch/arm/boot/dts/vf610.dtsi
> > @@ -140,6 +140,37 @@
> >  				clock-names = "pit";
> >  			};
> >
> > +			pwm0: pwm@...38000 {
> > +				compatible = "fsl,vf610-ftm-pwm";
> > +				#pwm-cells = <3>;
> > +				reg = <0x40038000 0x1000>;
> > +				clock-names = "ftm0", "ftm0_fix_sel",
> "ftm0_ext_sel";
> > +				clocks = <&clks VF610_CLK_FTM0>,
> > +					<&clks VF610_CLK_FTM0_FIX_SEL>,
> > +					<&clks VF610_CLK_FTM0_EXT_SEL>;
> > +				pinctrl-names = "ch0-active", "ch0-idle", "ch1-
> active", "ch1-idle",
> > +						"ch2-active", "ch2-idle", "ch3-
> active", "ch3-idle",
> > +						"ch4-active", "ch4-idle", "ch5-
> active", "ch5-idle",
> > +						"ch6-active", "ch6-idle", "ch7-
> active", "ch7-idle";
> > +				pinctrl-0 = <&pinctrl_pwm0_ch0_active>;
> > +				pinctrl-1 = <&pinctrl_pwm0_ch0_idle>;
> > +				pinctrl-2 = <&pinctrl_pwm0_ch1_active>;
> > +				pinctrl-3 = <&pinctrl_pwm0_ch1_idle>;
> > +				pinctrl-4 = <&pinctrl_pwm0_ch2_active>;
> > +				pinctrl-5 = <&pinctrl_pwm0_ch2_idle>;
> > +				pinctrl-6 = <&pinctrl_pwm0_ch3_active>;
> > +				pinctrl-7 = <&pinctrl_pwm0_ch3_idle>;
> > +				pinctrl-8 = <&pinctrl_pwm0_ch4_active>;
> > +				pinctrl-9 = <&pinctrl_pwm0_ch4_idle>;
> > +				pinctrl-10 = <&pinctrl_pwm0_ch5_active>;
> > +				pinctrl-11 = <&pinctrl_pwm0_ch5_idle>;
> > +				pinctrl-12 = <&pinctrl_pwm0_ch6_active>;
> > +				pinctrl-13 = <&pinctrl_pwm0_ch6_idle>;
> > +				pinctrl-14 = <&pinctrl_pwm0_ch7_active>;
> > +				pinctrl-15 = <&pinctrl_pwm0_ch7_idle>;
> > +				status = "disabled";
> > +			};
> 
> This is a SoC file, but the pinmux is board specific. The pinmux settings
> probably shouldn't be here.
> 
Yes, agreed.

I will revise it soon.

--
Xiubo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/