linux-kernel - Re: [PATCH] drm/i915/sdvo: Fully translate sync flags in the dtd->mode conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522EDB3D.7040504@t-online.de>
Date:	Tue, 10 Sep 2013 10:41:33 +0200
From:	Knut Petersen <Knut_Petersen@...nline.de>
To:	Daniel Vetter <daniel.vetter@...ll.ch>
CC:	Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>,
	ville.syrjala@...ux.intel.com
Subject: Re: [PATCH] drm/i915/sdvo: Fully translate sync flags in the dtd->mode
 conversion

On 10.09.2013 10:02, Daniel Vetter wrote:
> Instead of just a flag bit for each of the positive/negative sync
> modes drm actually uses a separate flag for each ... This upsets the
> modeset checker since the adjusted mode filled out at modeset time
> doesn't match the one reconstructed at check time (since the
> ->get_config callback already gets this right).
>
> Reported-by: Knut Petersen <Knut_Petersen@...nline.de>
> Cc: Knut Petersen <Knut_Petersen@...nline.de>
> References: http://www.gossamer-threads.com/lists/linux/kernel/1778688?do=post_view_threaded

Thanks for the patch, but it does _not_ cure the problem, see attached boot dmesg.

cu,
  Knut


> Signed-off-by: Daniel Vetter <daniel.vetter@...ll.ch>
> ---
>   drivers/gpu/drm/i915/intel_sdvo.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 85037b9..5033c74 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -866,8 +866,12 @@ static void intel_sdvo_get_mode_from_dtd(struct drm_display_mode * mode,
>   		mode->flags |= DRM_MODE_FLAG_INTERLACE;
>   	if (dtd->part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
>   		mode->flags |= DRM_MODE_FLAG_PHSYNC;
> +	else
> +		mode->flags |= DRM_MODE_FLAG_NHSYNC;
>   	if (dtd->part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
>   		mode->flags |= DRM_MODE_FLAG_PVSYNC;
> +	else
> +		mode->flags |= DRM_MODE_FLAG_NVSYNC;
>   }
>   
>   static bool intel_sdvo_check_supp_encode(struct intel_sdvo *intel_sdvo)


View attachment "dmesg" of type "text/plain" (106244 bytes)