linux-kernel - Re: [PATCH] ACPI: Move acpi_bus_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1625559.QHokRTMI6X@vostro.rjw.lan>
Date:	Tue, 10 Sep 2013 13:30:44 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Jonathan Callen <jcallen@...too.org>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: Move acpi_bus_get_device() from bus.c to scan.c

On Monday, September 09, 2013 11:52:44 PM Jonathan Callen wrote:
> On 07/27/2013 09:24 AM, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com> Subject: ACPI: Move acpi_bus_get_device()
> > from bus.c to scan.c
> >
> > Move acpi_bus_get_device() from bus.c to scan.c which allows acpi_bus_data_handler() to become
> > static and clean up the latter.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> --- drivers/acpi/bus.c      |
> > 21 --------------------- drivers/acpi/scan.c     |   30 ++++++++++++++++++++++--------
> > include/acpi/acpi_bus.h |    1 - 3 files changed, 22 insertions(+), 30 deletions(-)
> >
> > Index: linux-pm/drivers/acpi/bus.c
> > =================================================================== ---
> > linux-pm.orig/drivers/acpi/bus.c +++ linux-pm/drivers/acpi/bus.c @@ -89,27 +89,6 @@ static
> > struct dmi_system_id dsdt_dmi_tab Device Management
> [cut]
> > - -EXPORT_SYMBOL(acpi_bus_get_device); - acpi_status acpi_bus_get_status_handle(acpi_handle
> > handle, unsigned long long *sta) { Index: linux-pm/drivers/acpi/scan.c
> > =================================================================== ---
> > linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/scan.c @@ -970,6 +970,28 @@ struct
> > bus_type acpi_bus_type = { .uevent		= acpi_device_uevent, };
> >
> [cut]
> > +} +EXPORT_SYMBOL_GPL(acpi_bus_get_device); +
> 
> Was it intentional to change the EXPORT_SYMBOL to EXPORT_SYMBOL_GPL here?

Yes, it was.

> While I understand that it is completely unsupported anyway, this change does
> break at least the latest version of the proprietary nvidia graphics driver.

This commit has been in linux-next for over a month and no one has spoken
a word about this problem.  I'm not going to revert that change now, sorry.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/