linux-kernel - Re: [PATCH] workqueue: remove redundant timer_stats_timer_set_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130910134533.GB7275@htj.dyndns.org>
Date:	Tue, 10 Sep 2013 09:45:33 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Libin <huawei.libin@...wei.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, mingo@...hat.com, wangyijing@...wei.com,
	guohanjun@...wei.com
Subject: Re: [PATCH] workqueue: remove redundant
 timer_stats_timer_set_start_info() call

On Tue, Sep 10, 2013 at 02:35:27PM +0800, Libin wrote:
> From: Li Bin <huawei.libin@...wei.com>
> 
> There is a redundant call for timer_stats_timer_set_start_info(),
> because it is the responsibility of the 'timer add' function:
> 
> add_timer_on()
> |- timer_stats_timer_set_start_info()
> 
> add_timer()
> |- mod_timer()
> 	|- __mod_timer()
> 		|- timer_stats_timer_set_start_info()
> 
> So the calling here is redundant, remove it.

I think it's intentional to record the caller's address so that timers
from delayed_work items can be distinguished.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/