linux-kernel - Re: [PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130910161453.GA1904@gmail.com>
Date:	Tue, 10 Sep 2013 19:14:54 +0300
From:	Dan Aloni <alonid@...tram.com>
To:	Gustavo Padovan <gustavo@...ovan.org>,
	Marcel Holtmann <marcel@...tmann.org>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	Johan Hedberg <johan.hedberg@...il.com>
Subject: Re: [PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0
 [0a5c, 21e6]

On Tue, Sep 10, 2013 at 04:45:32PM +0100, Gustavo Padovan wrote:
> Hi Dan,
> 
> 2013-09-03 Dan Aloni <alonid@...tram.com>:
> 
> > Tested with this patch and a Bluetooth mouse on 3.10.10, on ThinkPad W530.
> > 
> > Bus 001 Device 004: ID 0a5c:21e6 Broadcom Corp. BCM20702 Bluetooth 4.0 [ThinkPad]
> > 
> > T:  Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#=  4 Spd=12  MxCh= 0
> > D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> > P:  Vendor=0a5c ProdID=21e6 Rev=01.12
> > S:  Manufacturer=Broadcom Corp
> > S:  Product=BCM20702A0
> > S:  SerialNumber=F4B7E2F6E438
> > C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> > I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> > I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> > I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> > I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> > 
> > Signed-off-by: Dan Aloni <alonid@...tram.com>
> > ---
> >  drivers/bluetooth/btusb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index de4cf4d..e6313f8 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -104,6 +104,7 @@ static struct usb_device_id btusb_table[] = {
> >  	{ USB_DEVICE(0x0b05, 0x17b5) },
> >  	{ USB_DEVICE(0x04ca, 0x2003) },
> >  	{ USB_DEVICE(0x0489, 0xe042) },
> > +	{ USB_DEVICE(0x0a5c, 0x21e6) },
> 
> In which kernel have you seen this issue? We have a generic rule to catch all
> 0x0a5c Broadcom devices. And before we added this the device ID for your
> device was there, so in theory your device always worked.

Seem you are correct. I verified just now that on 3.10.11 the device is 
detected without the patch.

Originally I rebased this patch for my laptop's kernel without noticing it 
isn't needed anymore.

-- 
Dan Aloni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/