linux-kernel - Re: [PATCH] fscache: check consistency does not decrement refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP1eJFy+dtwEVYbyTtYbH+CeXGfUDbUkaf-_YsJAn_VLvK4pg@mail.gmail.com>
Date:	Tue, 10 Sep 2013 12:45:11 -0400
From:	Milosz Tanski <milosz@...in.com>
To:	Sage Weil <sage@...tank.com>
Cc:	ceph-devel <ceph-devel@...r.kernel.org>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	"linux-cachefs@...hat.com" <linux-cachefs@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] fscache: check consistency does not decrement refcount

Sage,

Can you submit to the upstream next in your next round of fixes (with
David's ack).

Thanks,
- Milosz

P.S: Thanks David.

On Tue, Sep 10, 2013 at 8:34 AM, David Howells <dhowells@...hat.com> wrote:
> Milosz Tanski <milosz@...in.com> wrote:
>
>> __fscache_check_consistency() does not decrement the count of operations
>> active after it finishes in the success case. This leads to a hung tasks on
>> cookie de-registration (commonly in inode eviction).
>>
>> INFO: task kworker/1:2:4214 blocked for more than 120 seconds.
>> kworker/1:2     D ffff880443513fc0     0  4214      2 0x00000000
>> Workqueue: ceph-msgr con_work [libceph]
>>   ...
>> Call Trace:
>>  [<ffffffff81569fc6>] ? _raw_spin_unlock_irqrestore+0x16/0x20
>>  [<ffffffffa0016570>] ? fscache_wait_bit_interruptible+0x30/0x30 [fscache]
>>  [<ffffffff81568d09>] schedule+0x29/0x70
>>  [<ffffffffa001657e>] fscache_wait_atomic_t+0xe/0x20 [fscache]
>>  [<ffffffff815665cf>] out_of_line_wait_on_atomic_t+0x9f/0xe0
>>  [<ffffffff81083560>] ? autoremove_wake_function+0x40/0x40
>>  [<ffffffffa0015a9c>] __fscache_relinquish_cookie+0x15c/0x310 [fscache]
>>  [<ffffffffa00a4fae>] ceph_fscache_unregister_inode_cookie+0x3e/0x50 [ceph]
>>  [<ffffffffa007e373>] ceph_destroy_inode+0x33/0x200 [ceph]
>>  [<ffffffff811c13ae>] ? __fsnotify_inode_delete+0xe/0x10
>>  [<ffffffff8119ba1c>] destroy_inode+0x3c/0x70
>>  [<ffffffff8119bb69>] evict+0x119/0x1b0
>>
>> Signed-off-by: Milosz Tanski <milosz@...in.com>
>
> Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/