linux-kernel - Re: [PATCH 1/3] staging: usbip: stub_main: correctly handle return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130910204759.GA6329@mwanda>
Date:	Tue, 10 Sep 2013 23:47:59 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	navin patidar <navinp@...c.in>
Cc:	gregkh@...uxfoundation.org, mfm@...eddisk.com,
	devel@...verdev.osuosl.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: usbip: stub_main: correctly handle return
 value

On Tue, Sep 10, 2013 at 10:44:07AM +0530, navin patidar wrote:
> ret == 0 means success, anything else is failure.
> 

Hopefully, it's only returning negative error codes.  Otherwise it needs
a different fix.

There isn't an official kernel style on if "if (ret < 0)" is better than
"if (ret)".  Some subsystems have a preference but most don't care.
It's up to the maintainer to choose.

Your patch is fine, but the changelog is misleading.  It should just say
"I prefer the other style" instead of "This code is wrong and has buggy
error handling".

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/