linux-kernel - Re: [112/121] m32r: consistently use "suffix-$(...)"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <swftxht9vjk.wl%hirokazu.takata.wj@renesas.com>
Date:	Tue, 10 Sep 2013 12:59:11 +0900
From:	Hirokazu Takata <takata@...ux-m32r.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Hirokazu Takata <takata@...ux-m32r.org>
Subject: Re: [112/121] m32r: consistently use "suffix-$(...)"

Acked-by: Hirokazu Takata <takata@...ux-m32r.org>

Sorry, it is my old mistake that still remained in the m32r kernel.
Please apply this patch.

Thanks,

-- Takata

From: Ben Hutchings <ben@...adent.org.uk>
Subject: [112/121] m32r: consistently use "suffix-$(...)"
Date: Sun, 08 Sep 2013 03:52:01 +0100
> 3.2.51-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> commit df12aef6a19bb2d69859a94936bda0e6ccaf3327 upstream.
> 
> Commit a556bec9955c ("m32r: fix arch/m32r/boot/compressed/Makefile")
> changed "$(suffix_y)" to "$(suffix-y)", but didn't update any location
> where "suffix_y" is set, causing:
> 
>   make[5]: *** No rule to make target `arch/m32r/boot/compressed/vmlinux.bin.', needed by `arch/m32r/boot/compressed/piggy.o'.  Stop.
>   make[4]: *** [arch/m32r/boot/compressed/vmlinux] Error 2
>   make[3]: *** [zImage] Error 2
> 
> Correct the other locations to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Hirokazu Takata <takata@...ux-m32r.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  arch/m32r/boot/compressed/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/m32r/boot/compressed/Makefile b/arch/m32r/boot/compressed/Makefile
> index 177716b..01729c2 100644
> --- a/arch/m32r/boot/compressed/Makefile
> +++ b/arch/m32r/boot/compressed/Makefile
> @@ -43,9 +43,9 @@ endif
>  
>  OBJCOPYFLAGS += -R .empty_zero_page
>  
> -suffix_$(CONFIG_KERNEL_GZIP)	= gz
> -suffix_$(CONFIG_KERNEL_BZIP2)	= bz2
> -suffix_$(CONFIG_KERNEL_LZMA)	= lzma
> +suffix-$(CONFIG_KERNEL_GZIP)	= gz
> +suffix-$(CONFIG_KERNEL_BZIP2)	= bz2
> +suffix-$(CONFIG_KERNEL_LZMA)	= lzma
>  
>  $(obj)/piggy.o: $(obj)/vmlinux.scr $(obj)/vmlinux.bin.$(suffix-y) FORCE
>  	$(call if_changed,ld)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/