linux-kernel - Re: [PATCH] panic: call panic handlers before kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+-Hpe1hFH4z8dk1E8ASR4NxNYBH5j_PdgmwGAkWgcFEA@mail.gmail.com>
Date:	Tue, 10 Sep 2013 15:41:24 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Vikram Mulukutla <markivx@...eaurora.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH] panic: call panic handlers before kmsg_dump

On Thu, Jul 18, 2013 at 4:17 PM, Tony Luck <tony.luck@...il.com> wrote:
> On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook <keescook@...omium.org> wrote:
>> Since the panic handlers may produce additional information (via printk)
>> for the kernel log, it should be reported as part of the panic output
>> saved by kmsg_dump(). Without this re-ordering, nothing that adds
>> information to a panic will show up in pstore's view when kmsg_dump
>> runs, and is therefore not visible to crash reporting tools that examine
>> pstore output.
>
> Good point.
>
> Acked-by: Tony Luck <tony.luck@...el.com>

Can someone pick this patch up? If akpm doesn't want it, it could live
in the pstore tree maybe?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/