linux-kernel - Re: [PATCH v3 1/2] hwmon: (lm90) Add power control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522EA3A8.7040508@roeck-us.net>
Date:	Mon, 09 Sep 2013 21:44:24 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Wei Ni <wni@...dia.com>, Mark Brown <broonie@...nel.org>,
	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] hwmon: (lm90) Add power control

On 09/09/2013 09:13 PM, Stephen Warren wrote:
> On 09/09/2013 09:53 PM, Guenter Roeck wrote:
>> On 09/09/2013 08:40 PM, Stephen Warren wrote:
>>> On 09/09/2013 09:36 PM, Guenter Roeck wrote:
> ...
>>>> My understanding is that by adding regulator support you essentially
>>>> committed to adding regulators (if necessary dummy ones) for this driver
>>>> to all those platforms. This is quite similar to other drivers in the
>>>> same situation. Once you start along that route, you'll have to go it
>>>> all the way.
>>>
>>> By using regulator_get_optional(), the regulator should be optional,
>>> hence you only have to add it to platforms that need it.
>>>
>>
>> Earlier comments suggest that this is not the intended use case for
>> regulator_get_optional().
>
> Isn't the issue only whether the optional aspect of the regulator is
> implemented by:
>
> a) regulator_get_optional() returning failure, then the driver having to
> check for that and either using or not-using the regulator.
>
> b) regulator_get_optional() returning a dummy regulator automatically
> when none is specified in DT or the regulator lookup table, and hence
> the driver can always call regulator_enable/disable on the returned value.
>

I don't know. The regulator folks would have to answer that.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/