linux-kernel - Re: [PATCH] drm/omap: fix error return code in omap_dmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Sep 2013 07:26:47 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	David Airlie <airlied@...ux.ie>,
	Greg KH <gregkh@...uxfoundation.org>,
	Andy Gross <andy.gross@...com>, joe@...ches.com,
	yongjun_wei@...ndmicro.com.cn,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/omap: fix error return code in omap_dmm_probe()

On Wed, Sep 11, 2013 at 7:16 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fix to return -ENOMEM in the refill memory alloc error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Thanks

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 9b794c9..ab546c9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -675,6 +675,7 @@ static int omap_dmm_probe(struct platform_device *dev)
>                                 &omap_dmm->refill_pa, GFP_KERNEL);
>         if (!omap_dmm->refill_va) {
>                 dev_err(&dev->dev, "could not allocate refill memory\n");
> +               ret = -ENOMEM;
>                 goto fail;
>         }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/