linux-kernel - Re: [PATCH v2] cpu/mem hotplug: Add try_online_node() for cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Sep 2013 07:40:40 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, rjw@...k.pl,
	kosaki.motohiro@...fujitsu.com, kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH v2] cpu/mem hotplug: Add try_online_node() for cpu_up()

On Wed, 2013-09-11 at 11:32 +0900, Yasuaki Ishimatsu wrote:
> (2013/09/11 7:47), Toshi Kani wrote:
> > cpu_up() has #ifdef CONFIG_MEMORY_HOTPLUG code blocks, which
> > call mem_online_node() to put its node online if offlined and
> > then call build_all_zonelists() to initialize the zone list.
> > These steps are specific to memory hotplug, and should be
> > managed in mm/memory_hotplug.c.  lock_memory_hotplug() should
> > also be held for the whole steps.
> > 
> > For this reason, this patch replaces mem_online_node() with
> > try_online_node(), which performs the whole steps with
> > lock_memory_hotplug() held.  try_online_node() is named after
> > try_offline_node() as they have similar purpose.
> > 
> > There is no functional change in this patch.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@...com>
> > ---
> > v2: Added pr_err() in case of NULL pgdat in try_online_node().
> > ---
> 
> Thank you for updating it. It looks good to me.
> 
> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>

Thanks Yasuaki!
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/