linux-kernel - Re: [PATCH v2 2/6] extcon-gpio: Use gpio driver/chip debounce if supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522FD7E4.90101@roeck-us.net>
Date:	Tue, 10 Sep 2013 19:39:32 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Chanwoo Choi <cw00.choi@...sung.com>
CC:	linux-kernel@...r.kernel.org,
	MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH v2 2/6] extcon-gpio: Use gpio driver/chip debounce if
 supported

On 09/10/2013 07:29 PM, Chanwoo Choi wrote:
> On 09/11/2013 11:16 AM, Guenter Roeck wrote:
>>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>> v2: rephrase patch subject
>>      call gpio_set_debounce before registering extcon device,
>>      and set debounce_jiffies only if the call was not successful
>>
>>   drivers/extcon/extcon-gpio.c |    8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
>> index 77d35a7..e5a4405 100644
>> --- a/drivers/extcon/extcon-gpio.c
>> +++ b/drivers/extcon/extcon-gpio.c
>> @@ -100,7 +100,13 @@ static int gpio_extcon_probe(struct platform_device *pdev)
>>   	extcon_data->state_off = pdata->state_off;
>>   	if (pdata->state_on && pdata->state_off)
>>   		extcon_data->edev.print_state = extcon_gpio_print_state;
>> -	extcon_data->debounce_jiffies = msecs_to_jiffies(pdata->debounce);
>> +	if (pdata->debounce) {
>> +		ret = gpio_set_debounce(extcon_data->gpio,
>> +					pdata->debounce * 1000);
>> +		if (ret < 0)
>> +			extcon_data->debounce_jiffies =
>> +				msecs_to_jiffies(pdata->debounce);
>> +	}
>>
>>   	ret = extcon_dev_register(&extcon_data->edev, &pdev->dev);
>>   	if (ret < 0)
>>
>
> I'd like you to add patch description for patch feature.
> So I add a little description about using gpio_set_debounce()
>
> I modify patch name as following to maintain patch naming style of extcon.
> Before
> 	extcon-gpio: Do not unnecessarily initialize variables
> 	extcon-gpio: Use gpio driver/chip debounce if supported
> After
> 	extcon: gpio: Do not unnecessarily initialize variables
> 	extcon: gpio: Use gpio driver/chip debounce if supported
>
No problem. I'll try to remember next time. Too late for patch 3/6, though.
Sorry for that.

> Applied it on extcon-linus.
> You can check it on extcon-linus branch in a few minutes.
>
Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/