linux-kernel - Re: [linux-next-20130822] module: broken module versions?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130910172321.0392fea32f2a33e629a8204c@linux-foundation.org>
Date:	Tue, 10 Sep 2013 17:23:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	penguin-kernel@...ove.sakura.ne.jp
Cc:	ak@...ux.intel.com, viro@...IV.linux.org.uk, geert@...ux-m68k.org,
	dhowells@...hat.com, rusty@...tcorp.com.au,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-next-20130822] module: broken module versions?

On Tue, 27 Aug 2013 11:14:33 +0900 penguin-kernel@...ove.sakura.ne.jp wrote:

> I noticed that symbols which cause "disagrees about version of symbol" messages
> have crc == 0.
> 
> ---------- scripts/mod/modpost.c ----------
>  	/* CRC'd symbol */
>  	if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
>  		crc = (unsigned int) sym->st_value;
> +		if (!crc)
> +			fprintf(stderr, "symbol %s has crc=0 sym->st_shndx=%d\n",
> +				symname, sym->st_shndx);
>  		sym_update_crc(symname + strlen(CRC_PFX), mod, crc,
>  			       export);
>  	}
> ---------- scripts/mod/modpost.c ----------
> 
> I got below messages upon build.
> 
>   symbol __crc_sys_close has crc=0 sym->st_shndx=0
>   symbol __crc_path_is_under has crc=0 sym->st_shndx=0
>
> ...
>
> I continued bisection in this way and found that commit 5c019369 "syscalls.h:
> use gcc alias instead of assembler aliases for syscalls" started showing
> below messages upon build.
> 
>   WARNING: "ns_capable" [net/ipv6/sit.ko] has no CRC!
>   WARNING: "ns_capable" [net/ipv6/ipv6.ko] has no CRC!
>   WARNING: "sock_register" [net/ipv6/ipv6.ko] has no CRC!
>   WARNING: "ns_capable" [net/ipv4/ip_tunnel.ko] has no CRC!
>   WARNING: "inode_add_bytes" [fs/udf/udf.ko] has no CRC!
>   WARNING: "current_fs_time" [fs/udf/udf.ko] has no CRC!
>   WARNING: "do_sync_read" [fs/udf/udf.ko] has no CRC!
>   WARNING: "d_tmpfile" [fs/udf/udf.ko] has no CRC!
>   WARNING: "sys_close" [fs/binfmt_misc.ko] has no CRC!
>   WARNING: "current_fs_time" [fs/binfmt_misc.ko] has no CRC!
>   WARNING: "vm_brk" [fs/binfmt_aout.ko] has no CRC!
>   WARNING: "sys_close" [fs/autofs4/autofs4.ko] has no CRC!
>   WARNING: "schedule_timeout" [drivers/hid/usbhid/usbhid.ko] has no CRC!
> 
> Reverting commit 5c019369 from linux-next-20130822 solved this problem.

OK, thanks, I've dropped
syscallsh-use-gcc-alias-instead-of-assembler-aliases-for-syscalls.patch
and scripts-mod-modpostc-handle-non-abs-crc-symbols.patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/