linux-kernel - RE: [patch -resend] cpqarray: info leak in ida_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48275AD710FCA34184C2B6186B4016B32D0FD6A5@G6W2491.americas.hpqcorp.net>
Date:	Wed, 11 Sep 2013 17:23:06 +0000
From:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Chirag Kantharia <chirag.kantharia@...com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	ISS StorageDev <iss_storagedev@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Moritz Muehlenhoff <jmm@...ian.org>
Subject: RE: [patch -resend] cpqarray: info leak in ida_locked_ioctl()



-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@...cle.com] 
Sent: Wednesday, September 11, 2013 2:38 AM
To: Chirag Kantharia; Andrew Morton
Cc: ISS StorageDev; linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org; Moritz Muehlenhoff
Subject: [patch -resend] cpqarray: info leak in ida_locked_ioctl()

The pciinfo struct has a two byte hole after ->dev_fn so stack information could be leaked to the user.

This was assigned CVE-2013-2147.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Mike Miller <mike.miller@...com>

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index 639d26b..2b94403 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1193,6 +1193,7 @@ out_passthru:
 		ida_pci_info_struct pciinfo;
 
 		if (!arg) return -EINVAL;
+		memset(&pciinfo, 0, sizeof(pciinfo));
 		pciinfo.bus = host->pci_dev->bus->number;
 		pciinfo.dev_fn = host->pci_dev->devfn;
 		pciinfo.board_id = host->board_id;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/