linux-kernel - Re: [PATCH] drm/msm: fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Sep 2013 15:03:29 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, yongjun_wei@...ndmicro.com.cn,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm: fix potential NULL pointer dereference

On Wed, Sep 11, 2013 at 10:09 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> The dereference to 'pdata' should be moved below the NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Acked-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/msm/msm_gpu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
> index e1e1ec9..6b50e6b 100644
> --- a/drivers/gpu/drm/msm/msm_gpu.c
> +++ b/drivers/gpu/drm/msm/msm_gpu.c
> @@ -29,13 +29,14 @@
>  static void bs_init(struct msm_gpu *gpu, struct platform_device *pdev)
>  {
>         struct drm_device *dev = gpu->dev;
> -       struct kgsl_device_platform_data *pdata = pdev->dev.platform_data;
> +       struct kgsl_device_platform_data *pdata;
>
>         if (!pdev) {
>                 dev_err(dev->dev, "could not find dtv pdata\n");
>                 return;
>         }
>
> +       pdata = pdev->dev.platform_data;
>         if (pdata->bus_scale_table) {
>                 gpu->bsc = msm_bus_scale_register_client(pdata->bus_scale_table);
>                 DBG("bus scale client: %08x", gpu->bsc);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/