linux-kernel - Re: [PATCH] vsprintf: drop comment claiming %n is ignored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Sep 2013 16:30:57 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Kees Cook <keescook@...omium.org>,
	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	George Spelvin <linux@...izon.com>,
	Jiri Kosina <jkosina@...e.cz>, Jan Beulich <jbeulich@...e.com>,
	Eldad Zack <eldad@...refinery.com>, kosaki.motohiro@...il.com
Subject: Re: [PATCH] vsprintf: drop comment claiming %n is ignored

> Yeah, just found those too.
> ---
>   fs/proc/consoles.c   |  2 +-
>   fs/proc/nommu.c      | 20 ++++++++++----------
>   fs/proc/task_mmu.c   | 18 +++++++++---------
>   fs/proc/task_nommu.c | 20 ++++++++++----------
>   4 files changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/fs/proc/consoles.c b/fs/proc/consoles.c
> index b701eaa..42f2bb7 100644
> --- a/fs/proc/consoles.c
> +++ b/fs/proc/consoles.c
> @@ -47,7 +47,7 @@ static int show_console_dev(struct seq_file *m, void *v)
>   			con_flags[a].name : ' ';
>   	flags[a] = 0;
>
> -	seq_printf(m, "%s%d%n", con->name, con->index, &len);
> +	len = seq_printf(m, "%s%d", con->name, con->index);
>   	len = 21 - len;
>   	if (len < 1)
>   		len = 1;
> diff --git a/fs/proc/nommu.c b/fs/proc/nommu.c
> index ccfd99b..91cfd19 100644
> --- a/fs/proc/nommu.c
> +++ b/fs/proc/nommu.c
> @@ -50,16 +50,16 @@ static int nommu_region_show(struct seq_file *m, struct vm_region *region)
>   		ino = inode->i_ino;
>   	}
>
> -	seq_printf(m,
> -		   "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu %n",
> -		   region->vm_start,
> -		   region->vm_end,
> -		   flags & VM_READ ? 'r' : '-',
> -		   flags & VM_WRITE ? 'w' : '-',
> -		   flags & VM_EXEC ? 'x' : '-',
> -		   flags & VM_MAYSHARE ? flags & VM_SHARED ? 'S' : 's' : 'p',
> -		   ((loff_t)region->vm_pgoff) << PAGE_SHIFT,
> -		   MAJOR(dev), MINOR(dev), ino, &len);
> +	len = seq_printf(m, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu ",
> +			 region->vm_start,
> +			 region->vm_end,
> +			 flags & VM_READ ? 'r' : '-',
> +			 flags & VM_WRITE ? 'w' : '-',
> +			 flags & VM_EXEC ? 'x' : '-',
> +			 flags & VM_MAYSHARE ?
> +			 flags & VM_SHARED ? 'S' : 's' : 'p',
> +			 ((loff_t)region->vm_pgoff) << PAGE_SHIFT,
> +			 MAJOR(dev), MINOR(dev), ino);
>
>   	if (file) {
>   		len = 25 + sizeof(void *) * 6 - len;
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 107d026..f84ee9f 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -286,15 +286,15 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
>   	if (stack_guard_page_end(vma, end))
>   		end -= PAGE_SIZE;
>
> -	seq_printf(m, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu %n",
> -			start,
> -			end,
> -			flags & VM_READ ? 'r' : '-',
> -			flags & VM_WRITE ? 'w' : '-',
> -			flags & VM_EXEC ? 'x' : '-',
> -			flags & VM_MAYSHARE ? 's' : 'p',
> -			pgoff,
> -			MAJOR(dev), MINOR(dev), ino, &len);
> +	len = seq_printf(m, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu ",
> +			 start,
> +			 end,
> +			 flags & VM_READ ? 'r' : '-',
> +			 flags & VM_WRITE ? 'w' : '-',
> +			 flags & VM_EXEC ? 'x' : '-',
> +			 flags & VM_MAYSHARE ? 's' : 'p',
> +			 pgoff,
> +			 MAJOR(dev), MINOR(dev), ino);
>
>   	/*
>   	 * Print the dentry name for named mappings, and a
> diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
> index 56123a6..1d7bbe5 100644
> --- a/fs/proc/task_nommu.c
> +++ b/fs/proc/task_nommu.c
> @@ -155,16 +155,16 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
>   		pgoff = (loff_t)vma->vm_pgoff << PAGE_SHIFT;
>   	}
>
> -	seq_printf(m,
> -		   "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu %n",
> -		   vma->vm_start,
> -		   vma->vm_end,
> -		   flags & VM_READ ? 'r' : '-',
> -		   flags & VM_WRITE ? 'w' : '-',
> -		   flags & VM_EXEC ? 'x' : '-',
> -		   flags & VM_MAYSHARE ? flags & VM_SHARED ? 'S' : 's' : 'p',
> -		   pgoff,
> -		   MAJOR(dev), MINOR(dev), ino, &len);
> +	len = seq_printf(m, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu ",
> +			 vma->vm_start,
> +			 vma->vm_end,
> +			 flags & VM_READ ? 'r' : '-',
> +			 flags & VM_WRITE ? 'w' : '-',
> +			 flags & VM_EXEC ? 'x' : '-',
> +			 flags & VM_MAYSHARE ?
> +			 flags & VM_SHARED ? 'S' : 's' : 'p',
> +			 pgoff,
> +			 MAJOR(dev), MINOR(dev), ino);
>
>   	if (file) {
>   		pad_len_spaces(m, len);

ack for mm parts.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/