| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <001701ceaf83$8921e6c0$9b65b440$%han@samsung.com> Date: Thu, 12 Sep 2013 15:44:31 +0900 From: Jingoo Han <jg1.han@...sung.com> To: 'Samuel Ortiz' <sameo@...ux.intel.com>, 'Lee Jones' <lee.jones@...aro.org> Cc: linux-kernel@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com> Subject: [PATCH 3/3] mfd: timberdale: remove unnecessary pci_set_drvdata() The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@...sung.com> --- drivers/mfd/timberdale.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c index a6755ec..084767b 100644 --- a/drivers/mfd/timberdale.c +++ b/drivers/mfd/timberdale.c @@ -829,12 +829,10 @@ err_config: err_ioremap: release_mem_region(priv->ctl_mapbase, CHIPCTLSIZE); err_request: - pci_set_drvdata(dev, NULL); err_start: pci_disable_device(dev); err_enable: kfree(priv); - pci_set_drvdata(dev, NULL); return -ENODEV; } @@ -851,7 +849,6 @@ static void timb_remove(struct pci_dev *dev) pci_disable_msix(dev); pci_disable_device(dev); - pci_set_drvdata(dev, NULL); kfree(priv); } -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists