linux-kernel - Re: [RFC PATCH v2 10/25] smp, metag: kill SMP single function call interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5231A233.1060900@imgtec.com>
Date:	Thu, 12 Sep 2013 12:14:59 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Jiang Liu <liuj97@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Shaohua Li <shli@...nel.org>, Jiang Liu <jiang.liu@...wei.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Steven Rostedt <rostedt@...dmis.org>,
	Jiri Kosina <trivial@...nel.org>,
	Wang YanQing <udknight@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	linux-metag <linux-metag@...r.kernel.org>
Subject: Re: [RFC PATCH v2 10/25] smp, metag: kill SMP single function call
 interrupt

On 11/09/13 17:07, Jiang Liu wrote:
> From: Jiang Liu <jiang.liu@...wei.com>
> 
> Commit 9a46ad6d6df3b54 "smp: make smp_call_function_many() use logic
> similar to smp_call_function_single()" has unified the way to handle
> single and multiple cross-CPU function calls. Now only one interrupt
> is needed for architecture specific code to support generic SMP function
> call interfaces, so kill the redundant single function call interrupt.
> 
> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
> Cc: Jiang Liu <liuj97@...il.com>

Seems to work.

Acked-by: James Hogan <james.hogan@...tec.com>

Cheers
James

> ---
>  arch/metag/include/asm/smp.h | 2 --
>  arch/metag/kernel/smp.c      | 6 +-----
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/metag/include/asm/smp.h b/arch/metag/include/asm/smp.h
> index e0373f8..1d7e770 100644
> --- a/arch/metag/include/asm/smp.h
> +++ b/arch/metag/include/asm/smp.h
> @@ -7,13 +7,11 @@
>  
>  enum ipi_msg_type {
>  	IPI_CALL_FUNC,
> -	IPI_CALL_FUNC_SINGLE,
>  	IPI_RESCHEDULE,
>  };
>  
>  extern void arch_send_call_function_single_ipi(int cpu);
>  extern void arch_send_call_function_ipi_mask(const struct cpumask *mask);
> -#define arch_send_call_function_ipi_mask arch_send_call_function_ipi_mask
>  
>  asmlinkage void secondary_start_kernel(void);
>  
> diff --git a/arch/metag/kernel/smp.c b/arch/metag/kernel/smp.c
> index 7c01131..5b3933b4 100644
> --- a/arch/metag/kernel/smp.c
> +++ b/arch/metag/kernel/smp.c
> @@ -491,7 +491,7 @@ void arch_send_call_function_ipi_mask(const struct cpumask *mask)
>  
>  void arch_send_call_function_single_ipi(int cpu)
>  {
> -	send_ipi_message(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE);
> +	send_ipi_message(cpumask_of(cpu), IPI_CALL_FUNC);
>  }
>  
>  void show_ipi_list(struct seq_file *p)
> @@ -546,10 +546,6 @@ static int do_IPI(struct pt_regs *regs)
>  			generic_smp_call_function_interrupt();
>  			break;
>  
> -		case IPI_CALL_FUNC_SINGLE:
> -			generic_smp_call_function_single_interrupt();
> -			break;
> -
>  		default:
>  			pr_crit("CPU%u: Unknown IPI message 0x%lx\n",
>  				cpu, nextmsg);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/