linux-kernel - Uninitialized rx_req/tx_req (was: Re: [PATCH v2 2/3] mmc: omap_hsmmc: Skip platform_get_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVVjkZBZyJe2qnUxHeRVo+8WD_Vx1ZKin_pA7XLRCW8uw@mail.gmail.com>
Date:	Thu, 12 Sep 2013 14:41:00 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Matt Porter <matt.porter@...aro.org>
Cc:	Balaji T K <balajitk@...com>, Chris Ball <cjb@...top.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Tony Lindgren <tony@...mide.com>,
	Devicetree Discuss <devicetree-discuss@...ts.ozlabs.org>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux MMC List <linux-mmc@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>, Dan Williams <djbw@...com>,
	Jon Hunter <jon-hunter@...com>,
	Santosh Shilimkar <santosh.shilimkar@...com>
Subject: Uninitialized rx_req/tx_req (was: Re: [PATCH v2 2/3] mmc: omap_hsmmc:
 Skip platform_get_resource_byname() for dt case)

On Tue, Mar 5, 2013 at 10:13 PM, Matt Porter <mporter@...com> wrote:
> From: Santosh Shilimkar <santosh.shilimkar@...com>
>
> MMC driver probe will abort for DT case because of failed
> platform_get_resource_byname() lookup. Fix it by skipping resource
> byname lookup for device tree build.
>
> Issue is hidden because hwmod popullates the IO resources which
> helps to succeed platform_get_resource_byname() and probe.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@...com>
> ---
>  drivers/mmc/host/omap_hsmmc.c |   28 +++++++++++++++-------------
>  1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index e79b12d..8ae1225 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1896,21 +1896,23 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
>
>         omap_hsmmc_conf_bus_power(host);
>
> -       res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "tx");
> -       if (!res) {
> -               dev_err(mmc_dev(host->mmc), "cannot get DMA TX channel\n");
> -               ret = -ENXIO;
> -               goto err_irq;
> -       }
> -       tx_req = res->start;
> +       if (!pdev->dev.of_node) {
> +               res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "tx");
> +               if (!res) {
> +                       dev_err(mmc_dev(host->mmc), "cannot get DMA TX channel\n");
> +                       ret = -ENXIO;
> +                       goto err_irq;
> +               }
> +               tx_req = res->start;
>
> -       res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "rx");
> -       if (!res) {
> -               dev_err(mmc_dev(host->mmc), "cannot get DMA RX channel\n");
> -               ret = -ENXIO;
> -               goto err_irq;
> +               res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "rx");
> +               if (!res) {
> +                       dev_err(mmc_dev(host->mmc), "cannot get DMA RX channel\n");
> +                       ret = -ENXIO;
> +                       goto err_irq;
> +               }
> +               rx_req = res->start;
>         }
> -       rx_req = res->start;
>
>         dma_cap_zero(mask);
>         dma_cap_set(DMA_SLAVE, mask);

Now this is in mainline, I get (gcc 4.1.2):

drivers/mmc/host/omap_hsmmc.c: In function ‘omap_hsmmc_probe’:
drivers/mmc/host/omap_hsmmc.c:1779: warning: ‘rx_req’ may be used
uninitialized in this function
drivers/mmc/host/omap_hsmmc.c:1779: warning: ‘tx_req’ may be used
uninitialized in this function

Indeed, rx_req and tx_req are not initialized in the DT case.

Initializing them to zero is probably not the right fix. Where are the values
supposed to come from in the DT case?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/