linux-kernel - Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130912150247.GB8619@hmsreliant.think-freely.org>
Date:	Thu, 12 Sep 2013 11:02:47 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] firmware: Be a bit more verbose about direct firmware
 loading failure

On Thu, Sep 12, 2013 at 10:30:59PM +0800, Ming Lei wrote:
> On Thu, Sep 12, 2013 at 9:16 PM, Neil Horman <nhorman@...driver.com> wrote:
> >>
> > Please re-read the patch, then point out to me which printk the above action
> > will trigger, because its not happening in my testing. If you'll take a look at
> > fw_get_filesystem_firmware, you'll see that if the filp_open on a firmware file
> > fails, we continue the for loop through the list of available search paths.  No
> > error is generated in the case you describe above.
> 
> You are right, sorry for missing "if (IS_ERR(file))  continue;",  and looks the
> patch is good.
> 
> Acked-by: Ming Lei <ming.lei@...onical.com>
> 
> Thanks,
Awesome, thanks!
Neil

> --
> Ming Lei
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/