linux-kernel - Re: [PATCH] mm/hwpoison: move set_migratetype_isolate() outside get_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130912152113.GH18242@two.firstfloor.org>
Date:	Thu, 12 Sep 2013 17:21:13 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Wanpeng Li <liwanp@...ux.vnet.ibm.com>,
	Tony Luck <tony.luck@...el.com>, gong.chen@...ux.intel.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/hwpoison: move set_migratetype_isolate() outside
 get_any_page()

On Thu, Sep 12, 2013 at 11:11:44AM -0400, Naoya Horiguchi wrote:
> Chen Gong pointed out that set/unset_migratetype_isolate() was done in
> different functions in mm/memory-failure.c, which makes the code less
> readable/maintenable. So this patch makes it done in soft_offline_page().
> 
> With this patch, we get to hold lock_memory_hotplug() longer but it's not
> a problem because races between memory hotplug and soft offline are very rare.
> 
> This patch is against next-20130910.
> 
> Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> Reviewed-by: Chen, Gong <gong.chen@...ux.intel.com>

Acked-by: Andi Kleen <ak@...ux.intel.com>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/