linux-kernel - Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Sep 2013 18:57:33 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Vince Weaver <vince@...ter.net>, Andi Kleen <ak@...ux.intel.com>,
	acme@...radead.org, linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	torvalds@...ux-foundation.org, trinity@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...il.com>
Subject: Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2

* Andi Kleen <andi@...stfloor.org> wrote:

> On Tue, Jul 23, 2013 at 05:27:43PM -0400, Vince Weaver wrote:
> > 
> > I hate having to justify why breaking the ABI is unacceptable.
> 
> Well it's a testing ABI, so we can do changes to it.
> 
> I hope you're not suggesting that perf cannot be extended anymore.

It obviously should remain extensible, limiting it to 'config' is rather 
stupid. If a parser sees something it cannot parse it should ignore that 
event.

Your feature to export 'precise' requirements on events looks useful to 
me. We could implement it not by special casing it implicitly but by 
saying that if ../format/precise contains something like:

   attr:240-241

then that's a natural extension of the config:X-Y format and should be 
interpreted to mean mean 2 bits in the perf attr field. I.e. we could go 
beyond the config bitfield.

Basically the whole perf_event_attr can be thought of as a 'giant 
bitfield', in which we can specify values to export an enumerated list of 
events from the kernel to tooling.

(Using attr:X-Y the config and config1 variants can be expressed as well, 
as the config fields are inside the attr structure.)

The positions within the perf_attr are an ABI, so this would work pretty 
well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/