linux-kernel - Re: [RFC PATCH 1/4] DRIVERS: IRQCHIP: Add crossbar irqchip driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130912205417.GA539@radagast>
Date:	Thu, 12 Sep 2013 15:54:17 -0500
From:	Felipe Balbi <balbi@...com>
To:	Sricharan R <r.sricharan@...com>
CC:	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-doc@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <tglx@...utronix.de>,
	<linus.walleij@...aro.org>, <santosh.shilimkar@...com>,
	<linux@....linux.org.uk>, <tony@...mide.com>, <rnayak@...com>
Subject: Re: [RFC PATCH 1/4] DRIVERS: IRQCHIP: Add crossbar irqchip driver

On Thu, Sep 12, 2013 at 09:09:08PM +0530, Sricharan R wrote:
> +unsigned int crossbar_request_irq(struct irq_data *d)
> +{
> +	int cb_no = d->hwirq;
> +	int virq = allocate_free_irq(cb_no);
> +	void *irq = &cb->crossbar_map[cb_no].hwirq;
> +	int err;
> +
> +	err = request_threaded_irq(virq, crossbar_irq, NULL,
> +				   0, "CROSSBAR", irq);

this is wrong, why don't you just set crossbar up as a chained handler.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)