linux-kernel - Re: Smatch messages that are not understood

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130912224312.GJ25896@mwanda>
Date:	Fri, 13 Sep 2013 01:43:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	smatch@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: Smatch messages that are not understood

On Thu, Sep 12, 2013 at 05:29:26PM -0500, Larry Finger wrote:
> Hi,
> 
> I am in the process of fixing smatch warnings and errors in the
> rtlwifi family of drivers. Most are straight forward; however, some
> routines show info messages originating from an inline routine in
> the header files as follows:
> 
>   CHECK   drivers/net/wireless/rtlwifi/rtl8192ce/dm.c
> include/linux/etherdevice.h:278 ether_addr_equal_64bits() info:
> ignoring unreachable code.
> include/linux/etherdevice.h:278 ether_addr_equal_64bits() info:
> ignoring unreachable code.
> 
> The source code is a current pull of the mainline git tree. I'm not
> sure if this is a subtle case of unreachable code that I do not see,
> or if it is a smatch bug.

include/linux/etherdevice.h
   275          if (sizeof(fold) == 8)
   276                  return zap_last_2bytes(fold) == 0;
   277  
   278          fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^
   279                                  (*(unsigned long *)(addr2 + 4)));

It's hitting the (sizeof(fold) == 8) and returning.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/