linux-kernel - Re: [PATCH] dma: pl330: Simplify irq allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5232DBED.5060903@monstr.eu>
Date:	Fri, 13 Sep 2013 11:33:33 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] dma: pl330: Simplify irq allocation

On 09/12/2013 03:42 PM, Vinod Koul wrote:
> On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote:
>> Use devm_request_irq function.
> 
> Applied, thanks

Thanks. I have one change in my tree which I would like to get to the mainline
but it will need more interaction with others pl330 users.
It is about adding support for interrupt per channel feature.
For our case we have 8 channels and every channel has specific interrupt
+ we have one abort IRQ.

Based on the binding and Linux code two changes are necessary.
1. Extend AMBA_NR_IRQS because we have 9 IRQs
2. Driver change which is just register irqs when they are available.

Are these two changes OK for you?

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)