linux-kernel - Re: [PATCH 2/4] scripts/config: use sed's POSIX interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B58F4964-E48A-4D56-ABEE-C8E9514B2651@gmail.com>
Date:	Fri, 13 Sep 2013 11:54:31 +0200
From:	Clément Chauplannaz <chauplac@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"Yann E. MORIN" <yann.morin.1998@...e.fr>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] scripts/config: use sed's POSIX interface

On Sep 13, 2013, at 11:32 AM, Linus Walleij <linus.walleij@...aro.org> wrote:

> On Fri, Sep 13, 2013 at 10:38 AM, Clément Chauplannaz
> <chauplac@...il.com> wrote:
> 
>> Thank you for this report. I was able to reproduce this bug and fix it.
> 
> Thanks! Tested and works fine.
Glad to read the patch solves your issue. Thanks for the quick feedback!
> 
>> My previous commit changed the separator between sed's substitute
>> command and its parameters, from ':' to '/'. The latter conflicted
>> with the slashes found in the value of variable CMDLINE, as provided
>> in your email.
> 
> Hm it could actually be useful to be able to have colons in a CMDLINE,
> I wonder if we can think about some better separator ... oh well that
> is another issue, all old scripts work now anyway.
Indeed config script may not work with all possible string values. My first concern for now was to fallback to previous interface. We may look into hardening the script later on.

Best regards,
Clement Chauplannaz--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/