linux-kernel - [PATCH v5 1/3] sched: Reduce overestimating rq->avg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1379096813-3032-2-git-send-email-jason.low2@hp.com>
Date:	Fri, 13 Sep 2013 11:26:51 -0700
From:	Jason Low <jason.low2@...com>
To:	mingo@...hat.com, peterz@...radead.org, jason.low2@...com
Cc:	linux-kernel@...r.kernel.org, efault@....de, pjt@...gle.com,
	preeti@...ux.vnet.ibm.com, akpm@...ux-foundation.org,
	mgorman@...e.de, riel@...hat.com, aswin@...com,
	scott.norton@...com, srikar@...ux.vnet.ibm.com, chegu_vinod@...com
Subject: [PATCH v5 1/3] sched: Reduce overestimating rq->avg_idle

When updating avg_idle, if the delta exceeds some max value, then avg_idle
gets set to the max, regardless of what the previous avg was. This can cause
avg_idle to often be overestimated.

This patch modifies the way we update avg_idle by always updating it with the
function call to update_avg() first. Then, if avg_idle exceeds the max, we set
it to the max.

Signed-off-by: Jason Low <jason.low2@...com>
Reviewed-by: Rik van Riel <riel@...hat.com>
Reviewed-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
---
 kernel/sched/core.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 725aa06..25b0f79 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1347,10 +1347,11 @@ ttwu_do_wakeup(struct rq *rq, struct task_struct *p, int wake_flags)
 		u64 delta = rq_clock(rq) - rq->idle_stamp;
 		u64 max = 2*sysctl_sched_migration_cost;
 
-		if (delta > max)
+		update_avg(&rq->avg_idle, delta);
+
+		if (rq->avg_idle > max)
 			rq->avg_idle = max;
-		else
-			update_avg(&rq->avg_idle, delta);
+
 		rq->idle_stamp = 0;
 	}
 #endif
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/