linux-kernel - [PATCH 1/1] infiniband: hw: fix uninitialized ‘old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1379093905-5968-1-git-send-email-antonio.alecrim@gmail.com>
Date:	Fri, 13 Sep 2013 14:38:25 -0300
From:	Antonio Alecrim Jr <antonio.alecrim@...il.com>
To:	Roland Dreier <roland@...nel.org>,
	Sean Hefty <sean.hefty@...el.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Antonio Alecrim Jr <antonio.alecrim@...il.com>
Subject: [PATCH 1/1] infiniband: hw: fix uninitialized ‘old_qps’

Added missing old_qps initialization in order to fix the following
    warnings:
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function
‘_ocrdma_modify_qp’:
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: warning: ‘old_qps’
may be used uninitialized in this function [-Wmaybe-uninitialized]
  status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps);

Signed-off-by: Antonio Alecrim Jr <antonio.alecrim@...il.com>
---
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index 6e982bb..da6c23f 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -1289,6 +1289,7 @@ int _ocrdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 
 	qp = get_ocrdma_qp(ibqp);
 	dev = qp->dev;
+	old_qps = get_ibqp_state(qp->state);
 	if (attr_mask & IB_QP_STATE)
 		status = ocrdma_qp_state_change(qp, attr->qp_state, &old_qps);
 	/* if new and previous states are same hw doesn't need to
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/