linux-kernel - Re: scripts/config: fix variable substitution command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACW0xKV-jh2Zfz1-s0xX-NxYBixEF8Hf90jEbo0oouFE18CdyQ@mail.gmail.com>
Date:	Sat, 14 Sep 2013 16:21:05 +0200
From:	Clément Chauplannaz <chauplac@...il.com>
To:	sedat.dilek@...il.com
Cc:	Michal Marek <mmarek@...e.cz>, linux-kbuild@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: scripts/config: fix variable substitution command

2013/9/14 Sedat Dilek <sedat.dilek@...il.com>:
> Hi,
>
> The ChangeLog from [1] says:
>
> Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
> the separator between sed `s' command and its parameters from ':' to
> '/'.
> Revert this change.
>
> Reported-and-tested-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Clement Chauplannaz <chauplac@...il.com>
> Signed-off-by: Michal Marek <mmarek@...e.cz>
>
> *** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 ***
> (Linus-tree)
>
> To quote [2] and see its EXAMPLE:
>
> "If you want to refer to a specific commit, don't just refer to the
> SHA-1 ID of the commit. Please also include the oneline summary of
> the commit, to make it easier for reviewers to know what it is about.
>
> Example:
>
> Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary
> platform_set_drvdata(), but left the variable "dev" unused,
> delete it."
>
> That's why the commit-id without the subject-line is no good help.
> It does not help anyone when you reference a local GIT or linux-kbuild
> GIT related commit-id.
>
> So, can you point me/us to the correct commit with subject, please?!
> Is this patch even "CC: stable"?
>
> Thanks.
>
> Regards,
> - Sedat -
>
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d
> [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112


Hi Sedat,

My apologies for that mistake. The initial commit, as present in Linus tree, is:
83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
POSIX interface

Thus, the commit message for this patch should read:
scripts/config: fix variable substitution command

Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
POSIX interface") accidentally changed the separator between sed `s' command
and its parameters from ':' to '/'.

Revert this change.

Reported-and-tested-by: Linus Walleij <linus.walleij@...aro.org>
Signed-off-by: Clement Chauplannaz <chauplac@...il.com>
Signed-off-by: Michal Marek <mmarek@...e.cz>


Regards,
Clement
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/