linux-kernel - Re: scripts/config: fix variable substitution command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130914233903.GD3444@free.fr>
Date:	Sun, 15 Sep 2013 01:39:03 +0200
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	Sedat Dilek <sedat.dilek@...il.com>
Cc:	Clément Chauplannaz <chauplac@...il.com>,
	Michal Marek <mmarek@...e.cz>, linux-kbuild@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: scripts/config: fix variable substitution command

Sedat, All,

On 2013-09-14 16:43 +0200, Sedat Dilek spake thusly:
> On Sat, Sep 14, 2013 at 4:21 PM, Clément Chauplannaz <chauplac@...il.com> wrote:
> > 2013/9/14 Sedat Dilek <sedat.dilek@...il.com>:
[--SNIP--]
> >> So, can you point me/us to the correct commit with subject, please?!
> >
> > My apologies for that mistake. The initial commit, as present in Linus tree, is:
> > 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
> > POSIX interface
> >
> > Thus, the commit message for this patch should read:
> > scripts/config: fix variable substitution command
> >
> > Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
> > POSIX interface") accidentally changed the separator between sed `s' command
> > and its parameters from ':' to '/'.
> >
> > Revert this change.
> >
> > Reported-and-tested-by: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Clement Chauplannaz <chauplac@...il.com>
> > Signed-off-by: Michal Marek <mmarek@...e.cz>
> >
> 
> What means "pending" [1]?

The current script had a latent bug that would trigger when the user want
to set a string that contains a colon ':'.

This behaviour was changed by Clément, and the bug was then about strings
with a '/' instead. This was a regression for some users.

The behaviour was then reverted to break on strings containing ':'.

What is pending is a final fix that will fix both cases.

> Pending in sense of "we are working on it" or in the sense of
> "exists-but-not-published".

The final fix is trivial and identified, so I guess that Clément has yet
had time to send the patch.

> I did not found a hint on the offline linux-kbuild ML.

That would be Michal's suggestion there:
    http://marc.info/?l=linux-kbuild&m=137907001305533&w=2

> BTW, the GIT repo of Yann is not browsable (which is sh*t for checking
> commits quickl, I don't want to be forced to checkout).

Yes, I know about that one. I've already notified the gitorious guys
about the issue, they supposedly fixed it, but it is broken again.

I will re-open my ticket in a moment.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/