linux-kernel - Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5234562D.5050803@kernel.org>
Date:	Sat, 14 Sep 2013 13:27:25 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	jic23@....ac.uk, arnd@...db.de, linus.walleij@...aro.org,
	denis.ciocca@...com, linux-iio@...r.kernel.org
Subject: Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor
 device names

On 09/14/13 13:14, Jonathan Cameron wrote:
> On 09/10/13 13:49, Lee Jones wrote:
>> Some of ST's sensors are appended with their sensor type and some
>> are not. For consistency we're extending the same naming convention
>> throughout.
>>
>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> Honestly I don't care either way on these, but consistency would definitely
> be good so applied to the togreg branch of iio.git
> 
> Thanks,

Actually change of plan. I'm going to hold off on these as this an ABI change.
Iritating though having these as completely inconsistent is, changing this
will change device identification from userspace which is not a good idea.

Sorry Lee, but we really shouldn't do this. I should have picked up on this
in the original driver reviews but that's hindsight for you.

>> ---
>>  drivers/iio/accel/st_accel.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
>> index c387763..d8d22e5 100644
>> --- a/drivers/iio/accel/st_accel.h
>> +++ b/drivers/iio/accel/st_accel.h
>> @@ -15,11 +15,11 @@
>>  #include <linux/iio/common/st_sensors.h>
>>  
>>  #define LSM303DLHC_ACCEL_DEV_NAME	"lsm303dlhc_accel"
>> -#define LIS3DH_ACCEL_DEV_NAME		"lis3dh"
>> +#define LIS3DH_ACCEL_DEV_NAME		"lis3dh_accel"
>>  #define LSM330D_ACCEL_DEV_NAME		"lsm330d_accel"
>>  #define LSM330DL_ACCEL_DEV_NAME		"lsm330dl_accel"
>>  #define LSM330DLC_ACCEL_DEV_NAME	"lsm330dlc_accel"
>> -#define LIS331DLH_ACCEL_DEV_NAME	"lis331dlh"
>> +#define LIS331DLH_ACCEL_DEV_NAME	"lis331dlh_accel"
>>  #define LSM303DL_ACCEL_DEV_NAME		"lsm303dl_accel"
>>  #define LSM303DLH_ACCEL_DEV_NAME	"lsm303dlh_accel"
>>  #define LSM303DLM_ACCEL_DEV_NAME	"lsm303dlm_accel"
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/