linux-kernel - Re: [PATCH v2] trace: show more and exactly help information about snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130914073138.1cd6026c@gandalf.local.home>
Date:	Sat, 14 Sep 2013 07:31:38 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Wang YanQing <udknight@...il.com>
Cc:	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] trace: show more and exactly help information about
 snapshot

On Sat, 14 Sep 2013 12:59:16 +0800
Wang YanQing <udknight@...il.com> wrote:

> Actually, they both are correct:
> 
> 	default:
> 		if (tr->allocated_snapshot) {
> 			if (iter->cpu_file == RING_BUFFER_ALL_CPUS)
> 				tracing_reset_online_cpus(&tr->max_buffer);
> 			else
> 				tracing_reset(&tr->max_buffer,	iter->cpu_file);
> 		}
> 		break;
> 	}
> 
> It does nothing if it isn't allocated.
> 
> Perhaps we need it to say "(but does not allocate or free)"
> 
> -- Steve
> 
> Signed-off-by: Wang YanQing <udknight@...il.com>
> ---
>  I think "Clears and frees" are reasonable, and
>  "Clears and allocates are not so reasonable, so
>  we don't need to say not allocate. But it is help 
>  information, so make it more clearer is also acceptable. :)

I'm getting ready to go to Linux Con / Linux Plumbers. I wont be able to
get to this before, and may not be able to get to it while I'm there.
As the original is technically correct, I'll put this into my 3.13
queue.

Thanks,

-- Steve


>  
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 7974ba2..d5f7c4d 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2760,7 +2760,7 @@ static void show_snapshot_main_help(struct seq_file *m)
>  	seq_printf(m, "# echo 0 > snapshot : Clears and frees snapshot buffer\n");
>  	seq_printf(m, "# echo 1 > snapshot : Allocates snapshot buffer, if not already allocated.\n");
>  	seq_printf(m, "#                      Takes a snapshot of the main buffer.\n");
> -	seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate)\n");
> +	seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate or free)\n");
>  	seq_printf(m, "#                      (Doesn't have to be '2' works with any number that\n");
>  	seq_printf(m, "#                       is not a '0' or '1')\n");
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/