linux-kernel - Re: [PATCH 1/2] ARM: msm: trout: fix 'pointer from integer' warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201309152036.18373.arnd@arndb.de>
Date:	Sun, 15 Sep 2013 20:36:18 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Josh Cartwright <joshc@...eaurora.org>
Cc:	David Brown <davidb@...eaurora.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arm@...nel.org
Subject: Re: [PATCH 1/2] ARM: msm: trout: fix 'pointer from integer' warnings

On Tuesday 10 September 2013, Josh Cartwright wrote:
> -#define TROUT_GPIO_INT_MASK0_REG            (0x0c)
> -#define TROUT_GPIO_INT_STAT0_REG            (0x0e)
> -#define TROUT_GPIO_INT_MASK1_REG            (0x14)
> -#define TROUT_GPIO_INT_STAT1_REG            (0x10)
> +#define TROUT_GPIO_INT_MASK0_REG            IOMEM(0x0c)
> +#define TROUT_GPIO_INT_STAT0_REG            IOMEM(0x0e)
> +#define TROUT_GPIO_INT_MASK1_REG            IOMEM(0x14)
> +#define TROUT_GPIO_INT_STAT1_REG            IOMEM(0x10)

This is wrong, the values above are offsets from TROUT_CPLD_BASE. Instead you
need to make that constant an __iomem token and leave these as integers.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/