linux-kernel - Re: [RFC PATCH] ES938 support for ES18xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Sep 2013 22:35:20 +0200
From:	Andreas Mohr <andi@...as.de>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	Andreas Mohr <andi@...as.de>, alsa-devel@...a-project.org,
	krzysztof.h1@...pl,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ES938 support for ES18xx driver

Hi,

On Sun, Sep 15, 2013 at 10:25:45PM +0200, Ondrej Zary wrote:
> On Sunday 15 September 2013 20:49:02 Andreas Mohr wrote:
> BTW. I've got an AZT3328 card and it works fine with your driver. Thanks for 
> it.

What!?!? I didn't quite expect any kernel dev to have that one, too ;)

(got several commits sitting here and waiting for submission though)

> I'm thinking about doing some reverse-engineering of thunderbird-based sound 
> cards (VLSI Thunderbird - Aztech PCI 368-DSP, Thunderbird Avenger - Philips 
> Acoustic/Seismic/Rhythmic Edge).

Oh, nice. I've got the Aztech PCI 368-DSP, too (that was somewhat obligatory
due to having written another Aztech card driver...).

And yeah, the PCI 368 (etc.) series does seem to be some rather heavy
support hole indeed, IIRC (especially as it's more modern PCI-based and not ISA).


> > So perhaps ES938 has (perhaps since it might more or less conform to
> > certain standards specs?) another control for PCM output switch as well
> > which would need implementing or simply isn't set properly?
> > (to clarify, we're talking about a switch which would cause output signal
> > to be grabbed pre or post the 3D manipulation block)
> 
> The good thing is that there's a datasheet available for ES938 - e.g. at 
> http://www.datasheetarchive.com/ES938-datasheet.html
> 
> The 3D switch works but the level doesn't. Maybe I should use only the 3 
> specific level values from the datasheet and not a variable scale. Or just 
> remove the level control completely as Windows driver does (there's only a 3D 
> switch).

Hmm. Perhaps they removed it "Since It Does Not Work"? ;-P


Thanks for hinting at the TLV control dB values thingy! Didn't know that such
thing existed, thus azt3328 does not have it (yet?).


> > Perhaps we could have a more verbose message here?
> > That ES938 surely must have some human-readable characteristics...
> > (hmm, what about "ES938 3D audio effects processor found!"?)
> > ((or "Detected ..."))
> 
> Yes, that's wrong - it's only for testing purposes. There should probably be 
> no message at all as the es18xx driver itself does not display anything if 
> everything is OK.

...or that, yeah.


> > Perhaps that check is not specific enough, i.e. it might be useful
> > to figure out a more precise check?
> 
> snd_es938_read_reg() checks that the returned data match the format used by 
> ES938. Maybe we can reread all the register values back after writing to be 
> sure.

Is there any chip ID/version register to be identified?

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/